RE: [PATCH v3 1/7] usb: onboard-hub: Add reset-gpio support

3 Oct 2024


      Hi Marek,
...
-----Original Message-----
From: Marek Vasut marex@denx.de
Sent: Tuesday, October 1, 2024 5:27 PM
To: Abbarapu, Venkatesh venkatesh.abbarapu@amd.com; u-boot@lists.denx.de
Cc: Simek, Michal michal.simek@amd.com; fabrice.gasnier@foss.st.com; git
(AMD-Xilinx) git@amd.com
Subject: Re: [PATCH v3 1/7] usb: onboard-hub: Add reset-gpio support
On 10/1/24 7:05 AM, Venkatesh Yadav Abbarapu wrote:
[...]
...
@@ -30,7 +40,24 @@ static int usb_onboard_hub_probe(struct udevice *dev)
   if (ret)
   	dev_err(dev, "can't enable vdd-supply: %d\n", ret);

return ret;


hub->reset_gpio = devm_gpiod_get_optional(dev, "reset",
				  GPIOD_IS_OUT |



GPIOD_ACTIVE_LOW);
...

/* property is optional, don't return error! */
if (hub->reset_gpio) {

if (!hub->reset_gpio)
   return 0;
<Venkatesh> As reset_gpio is optional property,  by returning 0 the i2c sequence wont be executed.
Thanks
Venkatesh
...
to reduce indent .
...

ret = dm_gpio_set_value(hub->reset_gpio, 1);


if (ret)


	return ret;



udelay(data->reset_us);



ret = dm_gpio_set_value(hub->reset_gpio, 0);


if (ret)


	return ret;



udelay(data->power_on_delay_us);


}

return 0;
}

[...]

    