On 15.02.2018 09:59, Lukasz Majewski wrote:
On Thu, 15 Feb 2018 07:08:55 +0100 Andre Heider a.heider@gmail.com wrote:
Cosmetic change.
Hm, this got introduced by commit 9b643e312d52 ("treewide: replace with error() with pr_err()")
error() did print the newline...
Acked-by: Stefan Agner stefan.agner@toradex.com
Best regards, Stefan
Signed-off-by: Andre Heider a.heider@gmail.com
cmd/usb_gadget_sdp.c | 4 ++-- common/spl/spl_sdp.c | 4 ++-- drivers/usb/gadget/f_sdp.c | 14 +++++++------- 3 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/cmd/usb_gadget_sdp.c b/cmd/usb_gadget_sdp.c index ae4d73c125..97d00ec545 100644 --- a/cmd/usb_gadget_sdp.c +++ b/cmd/usb_gadget_sdp.c @@ -28,13 +28,13 @@ static int do_sdp(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) ret = sdp_init(controller_index); if (ret) {
pr_err("SDP init failed: %d", ret);
pr_err("SDP init failed: %d\n", ret);goto exit; }
/* This command typically does not return but jumps to an
image */ sdp_handle(controller_index);
- pr_err("SDP ended");
- pr_err("SDP ended\n");
exit: g_dnl_unregister(); diff --git a/common/spl/spl_sdp.c b/common/spl/spl_sdp.c index 333d518f4d..0c4603a3db 100644 --- a/common/spl/spl_sdp.c +++ b/common/spl/spl_sdp.c @@ -24,13 +24,13 @@ static int spl_sdp_load_image(struct spl_image_info *spl_image, ret = sdp_init(controller_index); if (ret) {
pr_err("SDP init failed: %d", ret);
pr_err("SDP init failed: %d\n", ret);return -ENODEV; }
/* This command typically does not return but jumps to an
image */ sdp_handle(controller_index);
- pr_err("SDP ended");
pr_err("SDP ended\n");
return -EINVAL;
} diff --git a/drivers/usb/gadget/f_sdp.c b/drivers/usb/gadget/f_sdp.c index dd7b9cddb1..6da0530095 100644 --- a/drivers/usb/gadget/f_sdp.c +++ b/drivers/usb/gadget/f_sdp.c @@ -238,12 +238,12 @@ static void sdp_rx_command_complete(struct usb_ep *ep, struct usb_request *req) u8 report = data[0];
if (status != 0) {
pr_err("Status: %d", status);
pr_err("Status: %d\n", status);return; }
if (report != 1) {
pr_err("Unexpected report %d", report);
pr_err("Unexpected report %d\n", report);@@ -323,12 +323,12 @@ static void sdp_rx_data_complete(struct usb_ep *ep, struct usb_request *req) int datalen = req->length - 1;
if (status != 0) {
pr_err("Status: %d", status);
pr_err("Status: %d\n", status);return; }
if (report != 2) {
pr_err("Unexpected report %d", report);
pr_err("Unexpected report %d\n", report);@@ -361,7 +361,7 @@ static void sdp_rx_data_complete(struct usb_ep *ep, struct usb_request *req) sdp->state = SDP_STATE_TX_SEC_CONF; break; default:
pr_err("Invalid state: %d", sdp->state);
pr_err("Invalid state: %d\n", sdp->state);}
@@ -371,7 +371,7 @@ static void sdp_tx_complete(struct usb_ep *ep, struct usb_request *req) int status = req->status;
if (status != 0) {
pr_err("Status: %d", status);
pr_err("Status: %d\n", status);@@ -394,7 +394,7 @@ static void sdp_tx_complete(struct usb_ep *ep, struct usb_request *req) sdp->state = SDP_STATE_IDLE; break; default:
pr_err("Wrong State: %d", sdp->state);
pr_err("Wrong State: %d\n", sdp->state);Reviewed-by: Lukasz Majewski lukma@denx.de
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de