On Friday, July 11, 2014 at 12:40:06 PM, Pavel Machek wrote:
[...]
- Copyright (C) 2012 Altera Corporation <www.altera.com>
- Copyright (C) 2014 Pavel Machek, pavel@denx.de
NAK ;-) Can you please keep the email address in this extremely relevant comment in the same format as above (in the <> chars) .
Umm, note that above is web address and mine is email address :-).
It still seems the email addresses are in those <> signs quite often ;-).
@@ -67,5 +68,11 @@ int overwrite_console(void)
/* We know all the init functions have been run now */ int board_eth_init(bd_t *bis) {
+#if !defined(CONFIG_SOCFPGA_VIRTUAL_TARGET) && !defined(CONFIG_SPL_BUILD) + /* initialize and register the emac */
- int rval = designware_initialize(CONFIG_EMAC_BASE,
CONFIG_PHY_INTERFACE_MODE); + return rval; +#else
return 0;
+#endif
}
Can this all not go into cpu_eth_init() and into arch/arm/... instead ?
No idea. When I move it to arch/arm/, like this, it still works, so I guess it can be moved.
Should I prepare new patch?
Yes please, but I can only give you a general guidance, I'm no socfpga expert.
Best regards, Marek Vasut