Re: [U-Boot] [[Patch V2] mips: 04/16] add cpu/mips64/cpu.c

On Friday 17 August 2012 11:30:47 Zhizhou Zhang wrote:

--- /dev/null +++ b/arch/mips/cpu/mips64/cpu.c

+void __attribute__((weak)) _machine_restart(void) +{ +}

change to __weak (include linux/compiler.h if you need to).

+int do_reset(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) +{

• _machine_restart();
• fprintf(stderr, "*** reset failed ***\n");
• return 0;

+}

this function should never return. add a __noreturn to machine_restart().

+void cache_probe()

(void) -mike