Hi Stefano,
On 11 août 2011, at 10:52, Stefano Babic wrote:
On 08/10/2011 10:33 PM, Eric Jarrige wrote:
Add i2c registers for Freescale imx1/L/S
Signed-off-by: Eric Jarrige eric.jarrige@armadeus.org Cc: Stefano Babic sbabic@denx.de
arch/arm/include/asm/arch-imx/imx-regs.h | 23 +++++++++++++++++++++++ 1 files changed, 23 insertions(+), 0 deletions(-)
Hi Eric,
+/*
- I2C module
- */
+#define IADR __REG(IMX_I2C_BASE + 0x000) /* I2C Address Register */ +#define IFDR __REG(IMX_I2C_BASE + 0x004) /* I2C Frequency Divider Register*/ +#define I2CR __REG(IMX_I2C_BASE + 0x008) /* I2C Control Register */ +#define I2SR __REG(IMX_I2C_BASE + 0x00C) /* I2C Status Register */ +#define I2DR __REG(IMX_I2C_BASE + 0x010) /* I2C Data I/O Register */
See my comments on your [PATCH 3/9] apf9328: Add Armadeus Project board APF9328. Access to registers must be done via accessors and __REG macro should be removed.
Ok, I remove the i2c driver from the apf9328 set of patches change the __REG macro to C struct and submit the i2c driver in a separate set of patches according to your comment in the [PATCH 3/9]
Cheers, Eric