
Hi J-C,
On Sun, May 3, 2009 at 3:21 AM, Jean-Christophe PLAGNIOL-VILLARD < plagnioj@jcrosoft.com> wrote:
--- /dev/null +++ b/include/dm9000.h
Ben what do you think to do as usb have a dir to store all net header include/net/
I have chosen the same location as the dm9161.h, other similar headers are there as well. If it has to be changed, I suggest making it a separate patch.
sure
I've in mind this
include/{ => net}/at91rm9200_net.h include/{ => net}/bcm5221.h include/{ => net}/dm9161.h include/{ => net}/dp83848.h include/{ => net}/lxt971a.h include/{ => net}/mii_phy.h include/{ => net}/miiphy.h include/{ => net}/ns7520_eth.h include/{ => net}/ns9750_eth.h include/{ => net}/ppc4xx_enet.h include/{ => net}/tsec.h
or
include/{ => net}/at91rm9200_net.h include/{ => net}/ns7520_eth.h include/{ => net}/ns9750_eth.h include/{ => net}/ppc4xx_enet.h include/{ => net}/tsec.h include/{ => net/phy}/bcm5221.h include/{ => net/phy}/dm9161.h include/{ => net/phy}/dp83848.h include/{ => net/phy}/lxt971a.h include/{ => net/phy}/mii_phy.h include/{ => net/phy}/miiphy.h
and maybe include/{ => net}/netdev.h
Best Regards, J.
I'm not crazy about this idea - it seems like unnecessary hierarchy when efforts could be diverted elsewhere. There are very few net-related public header files (as you've shown) and browsing through them, there's a lot of duplication of 802.3-defined PHY stuff and register definitions that are really private to the drivers themselves. Ideally we would have very little in the way of device-specific public functions apart from xxx_initialize(). I'm OK with having device-specific prototypes and struct definitions in netdev.h - that's what it was created for in the first place. As long as there's no code there (including static inlines) it seems appropriate.
regards, Ben