Hi Stefano,
On Friday 20 August 2010 10:10:49 am Stefano Babic wrote:
Hi Dave,
arch/arm/cpu/armv7/mx51/iomux.c | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-)
Probably iut is better you set a more useful comment in your commit. Instead of "Added support for mxc_iomux_set_input()", you can explain which is the new feature you provide. Something to explain you add a utility for the "daisy chain" pins, to control the input path to a module when the module can be connected to more as one pin.
Hmmm. I thought it was a trivial and obviously missing function to make iomux.c complete. Someone just needed to write it. I didn't think it needed any more explaining than that, but I'll do it in the next version of the patch set (will take a while).
The patch is part of a series. However, I can see only the first two patches. Is there something missing ? I do not see any relation between these two patches, too.
I sent 4 patches and received them all on the mailing-list. Are you sure you miss two of them? The first three patches introduce some minimal fixes/additions in order to implement the BSP for PRTLVT2 boards (patch 4/4).
+void mxc_iomux_set_input(iomux_input_select_t input, u32 config) +{
- u32 pad_reg = IOMUXSW_INPUT_CTL+(input*4);
Code styling, you should add spaces:
u32 pad_reg = IOMUXSW_INPUT_CTL + (input * 4);
Ok.
Best regards,