Re: [PATCH 5/7] usb: ehci-mx6: fix controller index for imx8m and imx8

29 Jun 2020

On 6/29/20 4:13 AM, Peng Fan wrote:
[...]
...

diff --git a/drivers/usb/host/ehci-mx6.c b/drivers/usb/host/ehci-mx6.c
index 046c6ab283..8090cb27fe 100644
--- a/drivers/usb/host/ehci-mx6.c
+++ b/drivers/usb/host/ehci-mx6.c
@@ -687,7 +687,11 @@ static int ehci_usb_bind(struct udevice *dev)
    * With these changes in place, the ad-hoc indexing goes away and
    * the driver is fully converted to DT probing.
    */

u32 controller_spacing = is_mx7() ? 0x10000 : 0x200;


u32 controller_spacing;
if (IS_ENABLED(CONFIG_MX6))
controller_spacing = 0x200;


else
controller_spacing = 0x10000;



This looks related to this problem:
501547cec1 ("usb: ehci-mx6: Fix bus enumeration for DM case")
Maybe instead of adding to the problem, it would make sense to convert
the driver to DM fully and then this problem with figuring out offsets
would go away ?

    

Marek Vasut