On 11/26/19 4:40 AM, Masahiro Yamada wrote:
On Thu, Nov 21, 2019 at 6:38 AM Marek Vasut wrote:
The SoCFPGA Gen5 does not have a clock driver yet, let the NAND driver work without a clock driver by falling back to the default frequencies.
Signed-off-by: Marek Vasut marex@denx.de Cc: Masahiro Yamada yamada.masahiro@socionext.com
drivers/mtd/nand/raw/denali_dt.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/mtd/nand/raw/denali_dt.c b/drivers/mtd/nand/raw/denali_dt.c index 0ce81324b9..2c9e249ab6 100644 --- a/drivers/mtd/nand/raw/denali_dt.c +++ b/drivers/mtd/nand/raw/denali_dt.c @@ -62,7 +62,6 @@ static int denali_dt_probe(struct udevice *dev) { struct denali_nand_info *denali = dev_get_priv(dev); const struct denali_dt_data *data;
struct clk clk, clk_x, clk_ecc; struct resource res; int ret;@@ -87,11 +86,14 @@ static int denali_dt_probe(struct udevice *dev)
denali->host = devm_ioremap(dev, res.start, resource_size(&res));+#if CONFIG_IS_ENABLED(CLK)
struct clk clk, clk_x, clk_ecc;ret = clk_get_by_name(dev, "nand", &clk); if (ret) ret = clk_get_by_index(dev, 0, &clk); if (ret)
return ret;
clk.dev = NULL;This line changes the 'clk' optional. Do you need additional #if CONFIG_IS_ENABLED(CLK) ?
This whole block is in such ifdef.
BTW, in Linux, clk_get() and clk_enable() are no-op when CONFIG_HAVE_CLK is unset.
The U-Boot's clk_get() returns -ENOSYS, hence drivers tend to be ugly. I already stopped caring the U-Boot code, though.
Because of the DM ?
[...]