On 08/04/2014 12:38 PM, Allen Martin wrote:
On Thu, Jul 31, 2014 at 04:21:43PM -0700, Stephen Warren wrote:
On 07/31/2014 05:14 PM, Allen Martin wrote:
Norrin (PM370) is a Tegra124 clamshell board that is very similar to venice2, but it has a different panel, the sdcard cd and wp sense are flipped, and it has a different revision of the AS3722 PMIC. This board is also refered to as "nyan" in the ChromeOS trees.
At a *very* quick glance, this looks OK. But, you'll need to do a bit of work to rebase it onto the latest u-boot/master. Kconfig has been introduced now, so you'll need to do at least:
- Don't touch boards.cfg (it's been removed)
- Add configs/norrin_defconfig
- Add board/nvidia/norrin/MAINTAINERS
I think that's it.
I based the patch on u-boot-tegra/master, is there a tegra branch that has already been rebased? Or has the upstream workflow changed, so we're not collecting patches on u-boot-tegra for next merge window?
Anything that gets applied will eventually have to merge with what's upstream from u-boot-tegra/master, so it's best to base patches on the main U-Boot repo rather than the Tegra repo, perhaps with the addition of any relevant patches from other trees that will get into the main U-Boot repo before your patches. The only exception would be small changes/fixes that you know are going into u-boot-tegra/master very quickly, during a time period when Tom is actively applying patches for a current pull request.
When Tom isn't actively applying patches to u-boot-tegra/master, that branch will sit still, containing the content of the previous pull request. It might stay in that state for a while, as u-boot/master etc. all advance. When Tom starts applying patches for a new pull request, he'll then update u-boot-tegra/master to start at some upstream point (which will pull in all the new upstream work) and then apply your patches. If your patches aren't based on that new upstream already, they won't apply correctly, and you or Tom will have to rebase them at that time.