On 28/11/2012 22:35, Wolfgang Denk wrote:
Dear Troy Kisky,
In message 50B67C99.8080609@boundarydevices.com you wrote:
But the reason I didn't include common.h is because of the target specific files that it also includes. Would you mind if I moved
Why would these hurt? They don't anywhere else.
Personally, I think that mkimage as generic tool should not include common.h. Doing that, it does not allow to compile mkimage without running config, and let's think that we need a different mkimage for each target, and that is not true. This will break also support from distros, because their packages (for example, u-boot-tools, uboot-mkimage under Ubuntu) are compiled without configuring u-boot - and I think it is correct.
IMHO we are discussing about a single macro. We can let it in mkimage as in patch and move it in a general file only if we will have a use case with a bunch of macros.
Best regards, Stefano Babic