Re: [U-Boot] universal_c210: fix compiler error and compiler warning

Dear Minkyu Kang,

In message 50C58623.3090308@samsung.com you wrote: ...

@@ -337,7 +341,7 @@ static void init_pmic_lcd(void) unsigned char val; int ret = 0;

• struct pmic *p = get_pmic();

• struct pmic *p = pmic_get("MAX8998_PMIC");

  if (pmic_probe(p)) return;

@@ -428,7 +432,7 @@ static void reset_lcd(void)

static void lcd_power_on(void) {

• struct pmic *p = get_pmic();

• struct pmic *p = pmic_get("MAX8998_PMIC");

  if (pmic_probe(p)) return;

This is unrelated to your patch - but what if pmic_get() returns NULL?

pmic_probe() will crashif you pass it a NULL pointer...

Best regards,

Wolfgang Denk