On Fri, May 18, 2018 at 10:42 PM Alex Kiernan alex.kiernan@gmail.com wrote:
Hi Sam On Fri, May 18, 2018 at 7:32 PM Sam Protsenko semen.protsenko@linaro.org wrote:
On 17 May 2018 at 19:13, Alex Kiernan alex.kiernan@gmail.com wrote:
Convert USB fastboot code to use shared fastboot protocol.
Signed-off-by: Alex Kiernan alex.kiernan@gmail.com
Changes in v2:
- remove redundant version.h
- use new fastboot_get_bytes_remaining() function
drivers/fastboot/Makefile | 4 +- drivers/usb/gadget/f_fastboot.c | 318
+++++-----------------------------------
2 files changed, 37 insertions(+), 285 deletions(-)
Hi Alex,
Unfortunately this patch breaks regular fastboot (over USB). At least on TI BeagleBoard X15. I tested your patch series using https://github.com/akiernan/u-boot.git, on branch us-fastboot-udp-v6 (hope it contains v2 of this patch). I'm unable to do "fastboot flash" or "fastboot oem format" commands after this patch. Below some debug output that can help you debug this issue.
Do you remember if you did the 'oem format' after the 'flash' command? If so, likely it's got out of sync and the 'oem format' was an innocent
victim
after the 'flash' failed...
There's definitely a change in the data transfer which looks like it
should
be fine, but I can imagine I've not got quite right.
I can see what I've done wrong... the transition into the USB download phase will never actually execute as I've put it inside an impossible conditional :(
I've pushed us-fastboot-udp-v6 which is everything apart from the USB migration, the USB migration (including this fix) is on us-fastboot-usb-v3