Hi Nishanth,
On Wed, 23 Aug 2023 at 18:18, Nishanth Menon nm@ti.com wrote:
On 17:57-20230823, Simon Glass wrote: [...]
This is how we have a common bit of rST for how to build N boards, without having to do a literal copy and paste N times.
How about using this?
https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#substitut...
I was not able to succeed with complex includes such as: https://github.com/u-boot/u-boot/blob/master/doc/board/ti/am62x_sk.rst?plain...
am62x complete build procedure defined once and reused in other am62x platforms.. But the am62x build procedure itself is reused from common k3 build steps.
I followed through these instructions. I find the env vars quite confusing, since I don't really know what it is doing. It feels like a script:
do $a $b $c do $f $e
it is pretty hard to follow. I think it would be better to write everything out in full for each board, like rockchip does.
Some other minor feedback:
- The 'make' lines should really have -j $(nproc) added - The $ signs at the start of each command in the docs are a pain since it stops me copying the commands into the terminal - can you remove them? - It doesn't build for me:
BINMAN .binman_stamp Image 'ti-dm' is missing external blobs and is non-functional: blob-ext
/binman/ti-dm/blob-ext (ti-dm/am62xx/ipc_echo_testb_mcu1_0_release_strip.xer5f): Missing blob
Some images are invalid make[1]: *** [/scratch/sglass/cosarm/src/third_party/u-boot/files/Makefile:1115: .binman_stamp] Error 103 make[1]: Leaving directory '/tmp/b/play' make: *** [Makefile:177: sub-make] Error 2
Regards, Simon