On 04/19/2017 10:58 AM, Ley Foon Tan wrote:
On Wed, Apr 19, 2017 at 4:53 PM, Marek Vasut marex@denx.de wrote:
On 04/19/2017 10:49 AM, Ley Foon Tan wrote:
On Wed, Apr 19, 2017 at 4:38 PM, Marek Vasut marex@denx.de wrote:
On 04/19/2017 05:32 AM, Ley Foon Tan wrote:
On Tue, Apr 18, 2017 at 6:58 PM, Marek Vasut marex@denx.de wrote:
On 04/18/2017 05:12 AM, Ley Foon Tan wrote: > On Mon, Apr 17, 2017 at 6:39 PM, Marek Vasut marex@denx.de wrote: >> On 04/17/2017 05:05 AM, Ley Foon Tan wrote: >>> On Fri, Apr 14, 2017 at 6:25 PM, Marek Vasut marex@denx.de wrote: >>>> On 04/13/2017 07:41 PM, Ley Foon Tan wrote: >>>>> Add config and defconfig for the Arria10 and update socfpga_common.h. >>>>> >>>>> Signed-off-by: Tien Fong Chee tien.fong.chee@intel.com >>>>> Signed-off-by: Ley Foon Tan ley.foon.tan@intel.com >>>> >>>> [...] >>>> >>>>> @@ -298,7 +306,10 @@ unsigned int cm_get_qspi_controller_clk_hz(void); >>>>> */ >>>>> #define CONFIG_SPL_FRAMEWORK >>>>> #define CONFIG_SPL_TEXT_BASE CONFIG_SYS_INIT_RAM_ADDR >>>>> -#define CONFIG_SPL_MAX_SIZE (64 * 1024) >>>>> +#define CONFIG_SPL_MAX_SIZE CONFIG_SYS_INIT_RAM_SIZE >>>>> +#if defined(CONFIG_TARGET_SOCFPGA_ARRIA10) >>>>> +#define CONFIG_SPL_BOARD_INIT >>>> >>>> This should be in Kconfig and selected by arch/arm/mach-socfpga/Kconfig >>>> entry for A10 >>> We can't use Kconfig method for CONFIG_SPL_BOARD_INIT, it is not a >>> Kconfig parameter now. >> >> OK. You can turn it into one, although that is out of the scope of this >> patchset. > Okay, I will add SPL_BOARD_INIT to arch/arm/mach-socfpga/Kconfig and > select it for Arria 10.
Do it in a separate patch please . Also, there's a script for turning symbols into Kconfig symbols in u-boot.
I think we don't need script if just add Kconfig to arch/arm/mach-socfpga/Kconfig, unless you want me add to common/spl/Kconfig and move this option to kconfig for all architectures.
That's what I had in mind, but please do it outside of this patchset, so this one can go in.
For this A10 patchset, I will add it to arch/arm/mach-socfpga/Kconfig first and I will send another patchset to add SPL_BOARD_INIT to common/spl/Kconfig on top of this patchset.
No, please don't, this will only introduce inconsistency.
So, we can get this patchset to get in first because move SPL_BOARD_INIT to kconfig for all architectures might take longer time to review . What do you think?
Just keep it as is now and ev. submit a separate patch which converts that to Kconfig later.
Okay, will keep SPL_BOARD_INIT in include/configs/socfpga_common.h as now first and send separate patchset to convert it to kconfig later.
Super, thanks