Hi Sumit,
On Sun, Mar 10, 2024 at 11:24 PM Sumit Garg sumit.garg@linaro.org wrote:
Hi Tony,
On Mon, 11 Mar 2024 at 09:20, Tony Dinh mibodhi@gmail.com wrote:
Hi Sumit, Hi Tom,
On Mon, Mar 4, 2024 at 4:29 AM Fabio Estevam festevam@gmail.com wrote:
On Mon, Mar 4, 2024 at 9:15 AM Sumit Garg sumit.garg@linaro.org wrote:
I suppose the earlier reference patch wasn't complete, can you rather try its v4 [1] instead?
[1] https://patchwork.ozlabs.org/project/uboot/patch/20240304121257.3551104-1-su...
This one works, thanks!
I'm testing this for a Marvell Armada 385 board (Synology DS116). I'm on the next branch, but perhaps something is still missing.
diff --git a/configs/ds116_defconfig b/configs/ds116_defconfig index 02ddc0e7918..1fbedcf91cf 100644 --- a/configs/ds116_defconfig +++ b/configs/ds116_defconfig @@ -16,7 +16,7 @@ CONFIG_SF_DEFAULT_SPEED=50000000 CONFIG_ENV_SIZE=0x10000 CONFIG_ENV_OFFSET=0x7E0000 CONFIG_ENV_SECT_SIZE=0x10000 -CONFIG_DEFAULT_DEVICE_TREE="armada-385-synology-ds116" +CONFIG_DEFAULT_DEVICE_TREE="marvell/armada-385-synology-ds116" CONFIG_SPL_TEXT_BASE=0x40000030 CONFIG_SPL_SERIAL=y CONFIG_SPL_STACK=0x4002c000 @@ -29,7 +29,6 @@ CONFIG_PCI=y CONFIG_DEBUG_UART=y CONFIG_AHCI=y CONFIG_BOOTSTD_FULL=y -CONFIG_BOOTSTD_DEFAULTS=y CONFIG_BOOTDELAY=10 CONFIG_USE_PREBOOT=y CONFIG_SYS_CONSOLE_INFO_QUIET=y @@ -57,6 +56,7 @@ CONFIG_CMD_CACHE=y CONFIG_CMD_TIME=y CONFIG_CMD_MTDPARTS=y CONFIG_MTDPARTS_DEFAULT="mtdparts=spi0.0:1m(u-boot),7040k(kernel),64k(u-boot-env),-(data)" +CONFIG_OF_UPSTREAM=y CONFIG_ENV_OVERWRITE=y CONFIG_SYS_RELOC_GD_ENV_ADDR=y CONFIG_VERSION_VARIABLE=y
# make ds116_defconfig
# grep -i ds116 .config CONFIG_SYS_BOARD="ds116" CONFIG_SYS_CONFIG_NAME="ds116" CONFIG_TARGET_DS116=y CONFIG_DEFAULT_DEVICE_TREE="marvell/armada-385-synology-ds116" CONFIG_IDENT_STRING="\nSynology DS116" CONFIG_SYS_PROMPT="DS116> " CONFIG_OF_LIST="marvell/armada-385-synology-ds116" CONFIG_SPL_OF_LIST="marvell/armada-385-synology-ds116"
Built it, and looks like vendor Marvell is missing during the Make file execution.
make -f ./scripts/Makefile.build obj=dts dtbs make -f ./scripts/Makefile.build obj=dts/upstream/src/arm dtbs scripts/Makefile.build:57: dts/upstream/src/arm/Makefile: No such file or directory
As you are building for the 32-bit Arm, you have to add a Makefile here [1] similar to this one [2] for arm64.
[1] https://source.denx.de/u-boot/u-boot/-/tree/next/dts/upstream/src/arm?ref_ty... [2] https://source.denx.de/u-boot/u-boot/-/blob/next/dts/upstream/src/arm64/Make...
Thanks! It works great with that Make file.
All the best, Tony
-Sumit
make[2]: *** No rule to make target 'dts/upstream/src/arm/Makefile'. Stop. make[1]: *** [dts/Makefile:54: arch-dtbs] Error 2 make: *** [Makefile:1166: dts/dt.dtb] Error 2 make: *** Waiting for unfinished jobs.... make: Leaving directory '/usr/src/u-boot'
I also tried Bryan's patch like you've suggested to Fabio. But it seems Bryan's patch was already in the next branch. Did I miss something?
All the best , Tony