On 9/25/24 8:13 AM, Chee, Tien Fong wrote:
Hi,
-----Original Message----- From: Marek Vasut marex@denx.de Sent: Wednesday, September 25, 2024 2:36 AM To: Chee, Tien Fong tien.fong.chee@intel.com; u-boot@lists.denx.de Cc: Simon Goldschmidt simon.k.r.goldschmidt@gmail.com; Meng, Tingting tingting.meng@intel.com; Yuslaimi, Alif Zakuan alif.zakuan.yuslaimi@intel.com; Hea, Kok Kiang kok.kiang.hea@intel.com Subject: Re: [PATCH v1 08/20] arm: dts: agilex5: Enable XGMAC
On 9/24/24 8:02 AM, Chee, Tien Fong wrote:
Hi,
Hi,
diff --git a/arch/arm/dts/socfpga_agilex5_socdk-u-boot.dtsi
b/arch/arm/dts/socfpga_agilex5_socdk-u-boot.dtsi
index 9eb21d65428..75ab05031bc 100644 --- a/arch/arm/dts/socfpga_agilex5_socdk-u-boot.dtsi +++ b/arch/arm/dts/socfpga_agilex5_socdk-u-boot.dtsi @@ -122,3 +122,36 @@ bootph-all; };
+&gmac0 {
- status = "okay";
- phy-mode = "rgmii";
- phy-handle = <&emac0_phy0>;
Shouldn't this be part of Linux DT already ?
This enablement not yet in Linux DT, I believe our Linux team is still working
on it. Is there at least a patch posted upstream ?
Having two patches posted now in Linux mainline, but gmac device is still not yet added into these dt. https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/intel/socf... https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/intel/socf...
I think we can do a cleanup if the duplicated found in U-Boot later.
At least reference the two patches (lore links) in the V2 of this patch.