On Tue, Jan 22, 2013 at 02:58:58PM -0800, Simon Glass wrote:
Hi Allen,
On Tue, Jan 22, 2013 at 2:48 PM, Allen Martin amartin@nvidia.com wrote:
On Tue, Jan 22, 2013 at 01:56:23PM -0800, Simon Glass wrote:
On Tue, Jan 22, 2013 at 1:42 PM, Allen Martin amartin@nvidia.com wrote:
Fix compiler warning about control flow reaching end of non void function.
Signed-off-by: Allen Martin amartin@nvidia.com
Should perhaps mention the commit that adding this warning (e05e5de7 I think)
Acked-by: Simon Glass sjg@chromium.org
It was this commit:
commit fec79acc864bed049b6beae719ccbf2bbec5403a Author: Mike Frysinger vapier@gentoo.org Date: Wed Oct 26 00:22:14 2011 +0000
sandbox: drop unused return Signed-off-by: Mike Frysinger <vapier@gentoo.org> Acked-by: Simon Glass <sjg@chromium.org>I'll change the commit messagen and repost and cc Mike as well.
Actually I think that Mike's commit was correct at the time, and it was Albert's which changed the no-return behaviour of the function signature in common.h?
Oh I see, you're right. I'll resend.
-Allen