Hello York,
-----Original Message----- From: York Sun Sent: Wednesday, October 04, 2017 8:22 PM To: Bogdan Purcareata bogdan.purcareata@nxp.com; Prabhakar Kushwaha prabhakar.kushwaha@nxp.com; Ashish Kumar ashish.kumar@nxp.com; u- boot@lists.denx.de Subject: Re: [PATCH] armv8: ls1088a: Update MC boot sequence
On 10/04/2017 02:10 AM, Bogdan Purcareata wrote:
This patch follows the work of previous commits: 5707dfb02e drivers: net: fsl-mc: Fixup MAC addresses in DPC 33a8991a87 drivers: net: fsl-mc: Link MC boot to PHY_RESET_R 1161dbcc0a drivers: net: fsl-mc: Include MAC addr fixup to DPL
These are not commit message. They belong to under the --- line under your signature.
I mentioned the patches to provide the overall context of the refactoring work.
Add support for LS1088 platforms, to make sure u-boot env MAC addresses are properly set in DPC / DPL.
This message doesn't match the change. You are removing mc_boot_env_var from qds and rdb files and replace it with a common function call to reset phy. You are not actually adding support for LS1088 platforms. Please revise your commit message.
I agree I was ambiguous there - I was referring to the support mentioned in the above patches.
I will send a v2 to incorporate your suggestions.
Thank you! Bogdan P.