Hi Sean,
On Mon, 13 Apr 2020 at 15:51, Sean Anderson seanga2@gmail.com wrote:
Patman outputs a line for every edition of the series in every patch, regardless of whether any changes were made. This can result in many redundant lines in patch changelogs, especially when a patch did not exist before a certain revision. For example, the existing behaviour could result in a changelog of
Changes in v7: None Changes in v6: None Changes in v5:
- Make a change
Changes in v4: None
Changes in v3:
- New
Changes in v2: None
With this patch applied and with --no-empty-changes, the same patch would look like
(no changes since v5)
Changes in v5:
- Make a change
Changes in v3:
- New
This is entirely aesthetic, but I think it reduces clutter, especially for patches added later on in a series.
Signed-off-by: Sean Anderson seanga2@gmail.com
Changes in v2:
- Add a note when there are no changes in the current revision
- Make this the default behaviour, and remove the option
tools/patman/patchstream.py | 2 +- tools/patman/series.py | 40 +++++++++++++++++++++++++++---------- 2 files changed, 30 insertions(+), 12 deletions(-)
Thanks for sending this series. I think the way that you have it working is fine.
But a few problems:
1. patman --test fails 2. The new behaviour needs a few tests, or at least test changes 3. I think you should mention the suppression of change-log info in the README 4. For me I see strange output:
Changes in v5: - This is my cover change
(no changes since v4)
Changes in v4: - Add linux/err.h header - Rename acpi-probed to linux,probed
5. Can you update your commit subjects to reflect what you are doing now?
Regards, Simon