21 Feb
2009
21 Feb
'09
10:42 p.m.
Dear Ben,
In message 49913D1C.6090905@denx.de Heiko Schocher wrote:
NetLoop polls every cycle with getenv some environment variables. This is horribly slow, especially when the environment is big.
This patch reads only the environment variables in NetLoop, when they were changed.
Also moved the init part of the NetLoop function in a seperate function.
Signed-off-by: Heiko Schocher hs@denx.de
changes since first patch:
- added comments from Wolfgang Denk
- added comments from Kim Philips without: I keep get_env_id (), because it looks better so to me
common/cmd_nvedit.c | 6 ++ include/common.h | 1 + net/eth.c | 11 ++++- net/net.c | 134 ++++++++++++++++++++++++++++---------------------- 4 files changed, 91 insertions(+), 61 deletions(-)
What about this patch? Will it go into v2009.03 ?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
And now remains That we find out the cause of this effect, Or rather
say, the cause of this defect... -- Hamlet, Act II, Scene 2