Hi Christophe,
On 3 October 2015 at 15:27, Simon Glass sjg@chromium.org wrote:
On 20 September 2015 at 21:00, Christophe Ricard christophe.ricard@gmail.com wrote:
As every TPM drivers support UCLASS_TPM, we can only rely on DM_TPM functions.
This simplify a bit the code.
Signed-off-by: Christophe Ricard christophe-h.ricard@st.com Reviewed-by: Tom Rini trini@konsulko.com
Changes in v3: None
common/cmd_tpm.c | 13 +-------- drivers/tpm/tpm_tis_infineon.c | 1 - include/tis.h | 60 ------------------------------------------ include/tpm.h | 6 ----- lib/tpm.c | 20 +++----------- 5 files changed, 4 insertions(+), 96 deletions(-) delete mode 100644 include/tis.h
Acked-by: Simon Glass sjg@chromium.org
I get errors with this patch:
04: dm: tpm: Remove every compilation switch for TPM driver model x86: + coreboot-x86 chromebook_link chromebox_panther -build/../common/cmd_tpm.c:504: undefined reference to `tis_sendrecv' -build/../lib/tpm.c:253: undefined reference to `tis_sendrecv' -build/../lib/tpm.c:276: undefined reference to `tis_init' -build/../lib/tpm.c:280: undefined reference to `tis_open' +common/built-in.o: In function `get_tpm': +build/../common/cmd_tpm.c:450: undefined reference to `uclass_first_device' +common/built-in.o: In function `do_tpm_info': +build/../common/cmd_tpm.c:469: undefined reference to `tpm_get_desc' +build/../common/cmd_tpm.c:498: undefined reference to `tpm_xfer' +build/../lib/tpm.c:245: undefined reference to `uclass_first_device' +build/../lib/tpm.c:248: undefined reference to `tpm_xfer' +build/../lib/tpm.c:264: undefined reference to `uclass_first_device' +build/../lib/tpm.c:267: undefined reference to `tpm_open' +../drivers/tpm/tpm_tis_lpc.c:19:17: fatal error: tis.h: No such file or directory + #include <tis.h> +compilation terminated. +make[3]: *** [drivers/tpm/tpm_tis_lpc.o] Error 1 +make[2]: *** [drivers/tpm] Error 2 +make[1]: *** [drivers] Error 2
Regards, Simon