24 Jan
2019
24 Jan
'19
9:10 p.m.
Am Do., 24. Jan. 2019, 21:05 hat Stephen Warren swarren@wwwdotorg.org geschrieben:
On 1/24/19 11:38 AM, Simon Goldschmidt wrote:
This unbreaks dfu mmc_file_op which is currently broken since using the load cmd on a buffer from heap is not allowed.
Tested-by: Stephen Warren swarren@nvidia.com
That was fast, thanks!
diff --git a/drivers/dfu/dfu_mmc.c b/drivers/dfu/dfu_mmc.c
static int mmc_file_op(enum dfu_op op, struct dfu_entity *dfu, void *buf, u64 *len) {
const char *fsname, *opname;char cmd_buf[DFU_CMD_BUF_SIZE];char *str_env;
char dev_part_str[DFU_CMD_BUF_SIZE];This can be a lot smaller now, but I guess it's fine as is.
This is why this is RFC. I wanted to find a way to prevent the conversion to string and back first.
Regards, Simon