Hi Michael,
On Tue, May 5, 2015 at 3:25 AM, Michael Walle michael@walle.cc wrote:
Hi Joe,
Am 2015-05-04 21:55, schrieb Joe Hershberger:
diff --git a/board/buffalo/lsxl/lsxl.c b/board/buffalo/lsxl/lsxl.c index 487875c..45dd788 100644 --- a/board/buffalo/lsxl/lsxl.c +++ b/board/buffalo/lsxl/lsxl.c @@ -230,16 +230,6 @@ static void rescue_mode(void) uchar enetaddr[6];
printf("Entering rescue mode..\n");-#ifdef CONFIG_RANDOM_MACADDR
if (!eth_getenv_enetaddr("ethaddr", enetaddr)) {net_random_ethaddr(enetaddr);if (eth_setenv_enetaddr("ethaddr", enetaddr)) {printf("Failed to set ethernet address\n");set_led(LED_ALARM_BLINKING);return;}}-#endif setenv("bootsource", "rescue"); }
NAK.
You removed the "set_led(LED_ALARM_BLINKING)". (Mh, I've just discovered, that there is an indentation error). This is very important for this board, because there is no other feedback to the user than the LED. Remember, there is no serial console by default for this board. Please provide some kind of callback where you can move the sed_led() call to.
The reason I removed it is because the only condition that was being checked for failure no longer happens at all. It only checked that the address could be written to the env. The policy is that the random address is not written to the env, but simply used for that boot. As such, there is nothing to fail.
Cheers, -Joe