Hi Jagan, Marek, Troy,
On 11/12/2015 16:24, Marek Vasut wrote:
On Friday, December 11, 2015 at 03:59:14 PM, Jagan Teki wrote:
On 11 December 2015 at 02:57, Troy Kisky troy.kisky@boundarydevices.com
wrote:
If GENMASK is REALLY desired, it should be GENMASK(23,0) But since GENMASK is obviously more confusing, let's just revert.
This reverts commit bad490a24212c068c5b718b9189f47ea4075d078.
Sorry, just fix genmask why revert? because driver author has no complaint on this, please don't just say simply "more confusing" more over I usually prefer reverting bug fix patches.
I also agree this GENMASK() crap is confusing.
IMHO it is easier for me to check directly the mask, as relying to a macro. But this is only my personal opinion.
On the other side, the GENMASK macro is taken from the kernel and it is used by several SOCs, in U-Boot too. Maybe we like to see directly the mask, but several users like use it and I should accept it. Both solutions (fixing GENMASK or revert it) are fine with me.
Today a new patch was sent :
http://patchwork.ozlabs.org/patch/556361/
same issue, fixing the GENMASK().
Troy's patch was assigned to me, but it belongs to SPI's custodian, so I move it to Jagan.
Best regards, Stefano Babic
Reviewed-by: Fabio Estevam fabio.estevam@freescale.com Signed-off-by: Troy Kisky troy.kisky@boundarydevices.com
v2: add sign off/ reviewed by
drivers/spi/fsl_qspi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/fsl_qspi.c b/drivers/spi/fsl_qspi.c index ed39114..dd7048a 100644 --- a/drivers/spi/fsl_qspi.c +++ b/drivers/spi/fsl_qspi.c @@ -24,7 +24,7 @@ DECLARE_GLOBAL_DATA_PTR;
#define TX_BUFFER_SIZE 0x40 #endif
-#define OFFSET_BITS_MASK GENMASK(24, 0) +#define OFFSET_BITS_MASK 0x00ffffff
#define FLASH_STATUS_WEL 0x02
-- 2.5.0
thanks!
Best regards, Marek Vasut