Hi Rasmus,
On 15.11.22 13:10, Rasmus Villemoes wrote:
On 14/11/2022 10.25, Heinrich Schuchardt wrote:
Correct GD_FLG_CYCLIC_RUNNING documentation to match Sphinx style.
Fixes: d7de5ef62935 ("cyclic: use a flag in gd->flags for recursion protection") Signed-off-by: Heinrich Schuchardt heinrich.schuchardt@canonical.com
Ack, obviously.
But now that I look in global_data.h again, it struck me that GD_FLG_WDT_READY has become write-only since c2fd0ca1a822. That is, it is set in initr_watchdog but nothing ever test for it.
So we should probably remove that bit (and that line in initr_watchdog), and then fill the vacant spot with GD_FLG_CYCLIC_RUNNING.
Good idea. I'll try to prepare a patch implementing this change tomorrow. Thanks for looking into this.
Thanks, Stefan