On Sun, 2014-07-06 at 22:54 +0200, Albert ARIBAUD wrote:
Hi Ian,
On Sun, 06 Jul 2014 20:22:31 +0100, Ian Campbell ijc@hellion.org.uk wrote:
On Sun, 2014-07-06 at 21:18 +0200, Albert ARIBAUD wrote:
Hi Ian,
Slightly off-topic, but... When you provide some code excerpt, you should make sure it doesn't look like a git patch, because if it does, then our Patchwork, which reads the list, will think it is actually a patch submission:
I suppose this was a submission, although I was mostly planning to short circuit it straight into the appropriate branch.
Hmm, short-circuiting a code change is risky -- all U-Boot code should go through the list and be reviewed.
Oh, I didn't mean to suggest skipping all that good stuff, just that the patch is already in a local branch ready to go when it is acked so I don't need to fetch it from patchwork.
Getting it reviewed was why I posted it.
If your post was a submission, then it should be the pure result of a git format-patch or of a patman command.
The thing I posted was the output of git format-patch.
How much do I need to corrupt something before patchwork will ignore it?
Basically, if you can (try to) 'git apply' the post, chances are PW will consider it a submission.
I think that is what I wanted on this occasion.
Ian.