Dear Heiko Schocher,
In message 1307610451-13457-1-git-send-email-hs@denx.de you wrote:
The U-Boot Design Principles[1] clearly say:
Initialize devices only when they are needed within U-Boot, i.e. don't initialize the Ethernet interface(s) unless U-Boot performs a download over Ethernet; don't initialize any IDE or USB devices unless U-Boot actually tries to load files from these, etc. (and don't forget to shut down these devices after using them - otherwise nasty things may happen when you try to boot your OS).
So, do not initialize and read the sensors on startup.
Signed-off-by: Heiko Schocher hs@denx.de cc: Wolfgang Denk wd@denx.de cc: Holger Brunck holger.brunck@keymile.com
Checkpatch says:
ERROR: do not initialise statics to 0 or NULL #111: FILE: common/cmd_dtt.c:31: +static unsigned long sensor_initialized = 0;
Please fix and resubmit.
Best regards,
Wolfgang Denk