Re: [PATCH 3/4] serial: s5p: Use named constants for register values

Hi Sam,

On Tue, 7 Nov 2023 at 12:06, Sam Protsenko semen.protsenko@linaro.org wrote:

Get rid of magic numbers in s5p_serial_init() when writing to UART registers. While at it, use BIT() macro for existing constants when appropriate.

No functional change.

Signed-off-by: Sam Protsenko semen.protsenko@linaro.org

drivers/serial/serial_s5p.c | 31 +++++++++++++++++++++---------- 1 file changed, 21 insertions(+), 10 deletions(-)

Reviewed-by: Simon Glass sjg@chromium.org