Hi York,
-----Original Message----- From: York Sun Sent: Tuesday, July 31, 2018 8:37 PM To: Calvin Johnson calvin.johnson@nxp.com; Scott Wood oss@buserror.net; Calvin Johnson linux.cj@gmail.com Cc: Jagdish Gediya jagdish.gediya@nxp.com; U-Boot Mailing List <u- boot@lists.denx.de> Subject: Re: [U-Boot] [PATCH] board: freescale: ls1012ardb: Add command to switch QSPI bank
On 04/19/2018 06:53 PM, Calvin Johnson wrote:
would be better. What this patch currently does can be done with simple env vars, like :
setenv boot_bank_1 'i2c mw 0x24 0x7 0xfc; i2c mw 0x24 0x3 0xf5' setenv boot_bank_2 'i2c mw 0x24 0x7 0xfc; i2c mw 0x24 0x3 0xf4'
...if the user knows to env reset those variables after the update (versus something that shows up in help), and if they don't get corrupted in a multi- user board farm environment, etc.
Make sense. Thanks!
Calvin,
Do you want to stay with env, or still want this patch, or standardize the command?
Ideally, a fully standardized generic command interface supporting all similar platforms with multiple banks as well as other boot sources such as NAND and MMC, is the best option.
This patch looks good as an interim solution.
Regards Calvin