Re: [U-Boot] [RFC][PATCH 1/3] DDR2: Support new JEDEC DDR2 SPD 1.3 spec

Hi Kyle,

<snip>

+/* These are all the types defined by the JEDEC DDR2 SPD 1.3 spec */ +#define SPD_DIMM_TYPE_UNDEFINED 0x00 +#define SPD_DIMM_TYPE_RDIMM 0x01 +#define SPD_DIMM_TYPE_UDIMM 0x02 +#define SPD_DIMM_TYPE_SO_DIMM 0x04 +#define SPD_DIMM_TYPE_72B_SO_CDIMM 0x06 +#define SPD_DIMM_TYPE_72B_SO_RDIMM 0x07 +#define SPD_DIMM_TYPE_MICRO_DIMM 0x08 +#define SPD_DIMM_TYPE_MINI_RDIMM 0x10 +#define SPD_DIMM_TYPE_MINI_UDIMM 0x20

These aren't 8xxx-specific, so they should go somewhere common. It looks like many of them are already defined in include/ddr_spd.h; I'd recommend adding new types there.

Best, Peter