On Fri, 21 Mar 2008 12:30:35 -0500 "Andy Fleming" afleming@gmail.com wrote:
Hm. I have a patch to clean up tsec initialization a bit. I'm wondering how this affects the tsec (and my patch). And there are other issues with calling the function something generic like that. The Freescale SOCs have 2 or more (I think we have 5 on one of our chips) TSEC devices. How do you deal with separating out multiple controllers?
Put multiple calls to the chip-specific init function in board_eth_initialize()
Also, won't this break if you have more than one type of controller on a board?
No, just make any sort of chip-specific init calls you need from board_eth_initialize().
The idea behind board_eth_initialize() is, if I get this correctly: * All board-specific knowledge (number and type of controllers, etc.) is contained within it. * It has the same name and signature on all boards, so we don't need a gazillion #ifdefs in net/eth.c * New boards don't need to patch anything under net/, so the probability of conflicts is reduced.
Haavard