Re: [U-Boot] [PATCH v3] AT91: Add SD/MMC controller support

On Sun, 22 Nov 2009 22:17 +0100, Wolfgang Denk wrote :

Dear Albin Tonnerre,

In message 1252442374-25386-1-git-send-email-albin.tonnerre@free-electrons.com you wrote:

...

This patch allows to use the atmel_mci SD/MMC driver on the at91 architecture. It contains:

• initialization code for the MCI controller for all the supported AT91. It allows the use of only one controller even if a SoC has two controllers (anyway there's no support for it in atmel_mci as of now)
• the necessary get_mci_clk_rate function
• definition of MMCI_BASE for use in atmel_mci
• the cpu_mmc_init function. As of now this is not used, but will be required when atmel_mci is ported to the new generic mmc API.

Signed-off-by: Albin Tonnerre albin.tonnerre@free-electrons.com Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagnioj@jcrosoft.com

---

Changes since v1

• Fix the MCI controller ID in the init code for CAP9, SAM9263 and SAM9G45
• Move AT91_BASE_MCI* define to soc header
• define AT91_BASE_MCI{0,1} instead of AT91_BASE_MCI for boards which have 2 controllers
• rework the way MMCI_BASE is defined accordingly

Changes since v2

• allow using 8-bit bus width on CPUs that support it
• change the arguments of atmel_mciX_hw_init to (slot, bus) so that it's more meaningful than (bitmask)

What's the current state of this patch? Do you consider it ripe for inclusion into mainline, or do you still have changes pending?

I consider it ready for inclusion. Thanks for the heads-up.

Regards,