Re: [U-Boot] [PATCH] fsl: board EEPROM has the CRC in the wrong location

On 07/13/2012 06:01 PM, Wolfgang Denk wrote:

Dear Timur Tabi,

In message 500098F6.8050702@freescale.com you wrote:

...

I honestly don't see what's wrong with checking the CRC in the old location, and using it if it's valid. Like I said, we already

You are interpreting something which can be random data.

...

if (e.version == 0) crc_offset = 0x72;

So here we're reading the 'version' field before we validate the data, because we need to check the version to know where the CRC is.

Argh. More crap ...

And how would you do it? You have to look at *something* first, and whatever that is could be a coincidence if you think people are going to stuff arbitrary data into the EEPROM.

-Scott