-----Original Message----- From: Albert ARIBAUD [mailto:albert.u.boot@aribaud.net] Sent: Monday, April 11, 2011 6:15 PM To: Prafulla Wadaskar Cc: u-boot@lists.denx.de; Clint Adams; Julian Pidancet Subject: Re: [U-Boot] [PATCH 2/2] Initialize second PHY on OpenRD-Client and OpenRD-Ultimate.
Hi Prafulle,
Le 11/04/2011 14:03, Prafulla Wadaskar a écrit :
board/Marvell/openrd_base/openrd_base.c | 22
++++++++++++++++++--
--
include/configs/openrd_base.h | 14 ++++++++++++--
Didn't Julian re-post patches that actually separates Base, Client
and
Ultimate into distinct config header files plus a common one? How
does
this affect Clint's patchset?
I acked for the method used here.
We don't need separate config headers. Using CONFIG_BOARD_IS_OPENRD_*
the boards related stuff can be identified.
If the two files above are to be used for all Open-RD boards (which is fine for me), then they should be renamed from openrd_base.* to openrd.* for the sake of clarity as to what they actually support.
Ack, I hope this will be addressed in next version.
Regards.. Prafulla . .
Amicalement,
Albert.