Re: [U-Boot-Users] A Shared flash.c

In message 21181-51126@sneakemail.com you wrote:

The JSE board (PPC405GPr) I'm working on has an 8-bit flash that is attached to the local bus, and I find that the flash.c from board/walnut405 is almost identical. (I just needed to add a case for a different chip vendor.) Would it make sense to move more of its contents to common/flash.c? For example,

It would make no sense, since there are about 137 other "flash.c" files which are not at all identical.

the flash_printinfo function seems like a candidate.

It ain't. Just compare a 5 or ten of the other flash drivers.

Would patches to that effect be accepted?

Probably not. Except you can convince me that it is possible.

Best regards,

Wolfgang Denk