Re: [U-Boot] [PATCH 1/2] ofnode: add ofnode_by_prop_value()

Hi Jens,

On 10 August 2018 at 06:54, Jens Wiklander jens.wiklander@linaro.org wrote:

Adds ofnode_by_prop_value() to search for nodes with a given property and value, an ofnode version of fdt_node_offset_by_prop_value().

Signed-off-by: Jens Wiklander jens.wiklander@linaro.org

drivers/core/of_access.c | 27 +++++++++++++++++++++++++++ drivers/core/ofnode.c | 14 ++++++++++++++ include/dm/of_access.h | 16 ++++++++++++++++ include/dm/ofnode.h | 14 ++++++++++++++ 4 files changed, 71 insertions(+)

This looks good, but please add some test code for this function.

E.g. at test/dm/ofnode.c

Regards, Simon