On 12:01-20230817, Manorit Chawdhry wrote: [...]
Is there a reason to go with proc-board instead of som-p0?
I see the same in k3-am625-r5-sk.dts..
#include "k3-am625-sk.dts" #include "k3-am62x-sk-ddr4-1600MTs.dtsi" #include "k3-am62-ddr.dtsi"
#include "k3-am625-sk-u-boot.dtsi"
And I believe the reason must be so that all the Linux fixes get propagated to R5 dts as I mentioned in the commit message.
if you are asking about the ordering - yes it is much easier to read and understand the include order. eventually the u-boot.dtsi will disappear once we have the boot phase properties merged into k.org (like I think j784s4 just did in the kernel Pull Request I sent out earlier this week for 6.6-rc1) leaving a minimal r5.dts (for the processor view differences) around.
[snip]
Include k3-j721s2-common-proc-board.dts file
Remove the duplicated pinmuxes from r5 and -u-boot.dtsi files and include k3-j721s2-common-proc-board.dts for Linux fixes to propagate to U-boot.
[snip]
Let me know if the reasoning is wrong..
If you are asking me for the reasoning of using board.dts vs som-p0.dts change, I am asking your rational since you did the change. ;) I think I see the reason that the common-proc-board.dts is the more accurate representation of the board. you can definitely argue that CONFIG_DEFAULT_DEVICE_TREE is using common-proc-board and som was a mistake.
&mcu_ringacc {
I see that you are overriding &mcu_udmap -> But I have not seen kernel patches to clean that up to introduce reg-names "rchan" "tchan" and "rflow".
I believe the patch is posted Nishanth if you are asking about mcu_udmap, I had added that in the cover letter, You can have a look at [0]. Vignesh is handling adding those nodes in Linux.
Thanks. Good to know this is being worked on.
Move the #include "k3-j721s2-common-proc-board-u-boot.dtsi" to the top.
The order should be:
#include "board.dts"
I see that you are also using board.dts here and not som-p0.dts, let me know what should be done about it. As I recall you having a previous comment mentioning about this.
Hope the explanations helped.