Hi Heinrich,
On Wed, 1 Dec 2021 at 11:08, Heinrich Schuchardt xypron.glpk@gmx.de wrote:
On 12/1/21 17:02, Simon Glass wrote:
This must be passed a ulong, not a u64. Fix it to avoid LTO warnings on sandbox.
Signed-off-by: Simon Glass sjg@chromium.org
lib/efi_loader/efi_acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/efi_loader/efi_acpi.c b/lib/efi_loader/efi_acpi.c index a62c34009cc..016bbf6db33 100644 --- a/lib/efi_loader/efi_acpi.c +++ b/lib/efi_loader/efi_acpi.c @@ -34,7 +34,7 @@ efi_status_t efi_acpi_register(void) * a 4k-aligned address, so it is safe to assume that * write_acpi_tables() will write the table at that address. */
write_acpi_tables(acpi);
write_acpi_tables((ulong)acpi);This is wrong: acpi is not an address in the virtual address space of the sandbox. You must not pass it to use map_sysmem() to convert it to a pointer.
I think you are referring to the other patch.
Here the problem is that a u64 is being passed to a ulong. As you say, this should be a global prototype and I will fix that in v2.
Please change the parameter of write_acpi_tables() to be a pointer and move all sandbox specific conversions to the sandbox code.
Sorry, no, I don't want to do that as it would be a significant departure from how U-Boot currently works. We use ulong everywhere for addresses.
Regards, Simon