On 15:15 Wed 17 Dec , Wolfgang Denk wrote:
Dear Jean-Christophe PLAGNIOL-VILLARD,
In message 20081217115717.GD26222@game.jcrosoft.org you wrote:
- enum { unknown, EDO, SDRAM, DDR2 } type;
- enum { unknown, edo, sdram, ddr2 } type;
Sorry again, but lower case enum labels violate the coding style either:
Chapter 12: Macros, Enums and RTL
Names of macros defining constants and labels in enums are capitalized.
so could you tell what do you wish to have (an example) __DDR2?
I don't really care about the exact variable name as long as it's standard conforming and does not violate the coding style.
__DDR2 would be obviuosly a very bad choice. Prefixing names with "_" or "__" is used only to reserve name spaces - which is not waht you're doing here.
Actually I don't understand at all why you want to change this file. Using "DDR2" as a local variable name is perfectly valid.
If there are problems because some stupid header file with global scope #defines a "DDR2" name that include file needs fixing, but not the C file here.
Yes that is the problem SDRAM is already use for other configuration
Maybe I need to rename the at91 to CONFIG_SYS_SDRAM
Best Regards, J.