Hello Steffen,
On 08.07.21 13:43, Steffen Jaeckel wrote:
Hi Heiko,
thanks for the review!
On 7/8/21 5:56 AM, Heiko Schocher wrote:
[...]
diff --git a/lib/crypt/Makefile b/lib/crypt/Makefile new file mode 100644 index 0000000000..290231064c --- /dev/null +++ b/lib/crypt/Makefile @@ -0,0 +1,10 @@ +# SPDX-License-Identifier: GPL-2.0+ +# +# Copyright (c) 2013, Google Inc. +# +# (C) Copyright 2000-2007 +# Wolfgang Denk, DENX Software Engineering, wd@denx.de.
Hmm... this is a new file ... I think you should add only your Copyright and drop the others... ?
thx, done
[...]
I miss here the SPDX license identifier... also some hint, from which exact version this code is from ...
I've added this info in the next commit, this contains the vanilla version. Is this ok?
Yes from my side, thanks!
bye, Heiko
Cheers, Steffen