On 14/01/13 15:32, Rajeshwari Birje wrote:
Hi Minkyu Kang,
OK, but is this something you intend to fix, perhaps in a future series? It seems like you need separate directories sooner rather than later.I don't think this is board-specific code, but chip-specific.
Please do let me know your opinion on the above comment.
Regards, Rajeshwari Shinde.
On Fri, Jan 11, 2013 at 7:54 PM, Simon Glass sjg@chromium.org wrote:
Hi Rajeshwari,
On Fri, Jan 11, 2013 at 2:43 AM, Rajeshwari Birje rajeshwari.birje@gmail.com wrote:
Hi Simon,
Thank you for comments.
On Thu, Jan 10, 2013 at 11:04 PM, Simon Glass sjg@chromium.org wrote:
Hi Rajeshwari,
On Mon, Jan 7, 2013 at 5:08 AM, Rajeshwari Shinde rajeshwari.s@samsung.com wrote:
This patch converts lowlevel_init.S to lowlevel_init_c.c for SMDK5250. Lowlevel.S as of now added only for SMDK5250 and same can be extended to other SOC in future.
Should perhaps also mention new feature (controllable memory reset for resume?)
-OK
Signed-off-by: Rajeshwari Shinde rajeshwari.s@samsung.com
Changes in V2: - Renamed lowlevel_init.S to lowlevel.S and moved to arch/arm/cpu/armv7/exynos/ - Moved power mode defines to power.h - Added early serial support. - Renamed mem_reset to reset. arch/arm/cpu/armv7/exynos/Makefile | 6 ++ arch/arm/cpu/armv7/exynos/lowlevel.S | 35 ++++++++ arch/arm/include/asm/arch-exynos/power.h | 8 ++ board/samsung/smdk5250/Makefile | 2 +- board/samsung/smdk5250/dmc_common.c | 4 +- board/samsung/smdk5250/dmc_init_ddr3.c | 6 +- board/samsung/smdk5250/lowlevel_init.S | 96 -------------------- board/samsung/smdk5250/lowlevel_init.c | 81 +++++++++++++++++
Any change we could move all of this to arch/arm/cpu/armv7/exynos...?
We do not have a separate directory for exynos5 and exynos4 and if we add all these files in arch/arm/cpu/armv7/exynos it would break the compilation for EXYNOS4. Also Later versions of exynos5 have different memory and timing variants.
OK, but is this something you intend to fix, perhaps in a future series? It seems like you need separate directories sooner rather than later.I don't think this is board-specific code, but chip-specific.
We don't have to separate directory for exynos5 and exynos4. We can check this by cpu_is_exynos5 or cpu_is_exynos4. I think each SoCs have different memory and timing but the logic can be same. If so we can move all of changes to SoC directory.
-- Thanks, Minkyu Kang.