Re: [U-Boot] [PATCH 2/3] dt: bcm6858: watchdog should use a 50Mhz clock

On 03.05.19 19:43, Philippe Reynes wrote:

The watchdog should use a clock at 50 Mhz, so instead of using the clock osc (200 Mhz), we define a reference clock at 50Mhz and use it for both watchdog.

Just curious: Why is this the case? Is this also what's done in the Linux DT version?

Other than that:

Reviewed-by: Stefan Roese sr@denx.de

Thanks, Stefan

Signed-off-by: Philippe Reynes philippe.reynes@softathome.com

arch/arm/dts/bcm6858.dtsi | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/arch/arm/dts/bcm6858.dtsi b/arch/arm/dts/bcm6858.dtsi index 76ba0ea..91f7787 100644 --- a/arch/arm/dts/bcm6858.dtsi +++ b/arch/arm/dts/bcm6858.dtsi @@ -66,6 +66,12 @@ clock-frequency = <200000000>; u-boot,dm-pre-reloc; };

• refclk50mhz: refclk50mhz {
  

• 	compatible = "fixed-clock";
  

• 	#clock-cells = <0>;
  

• 	clock-frequency = <50000000>;
  

• };
  

  };

  ubus {

@@ -92,13 +98,13 @@ wdt1: watchdog@ff802780 { compatible = "brcm,bcm6345-wdt"; reg = <0x0 0xff802780 0x0 0x14>;

• 	clocks = <&periph_osc>;
  

• 	clocks = <&refclk50mhz>;
  

  };

  wdt2: watchdog@ff8027c0 { compatible = "brcm,bcm6345-wdt"; reg = <0x0 0xff8027c0 0x0 0x14>;

• 	clocks = <&periph_osc>;
  

• 	clocks = <&refclk50mhz>;
  

  };

  wdt-reboot {

Viele Grüße, Stefan