:) I did not know about that, thanks.
On Thu, 25 Apr 2019 15:35:10 +0200 Pierre Bourdon delroth@gmail.com wrote:
On Thu, Apr 25, 2019 at 3:30 PM Marek Behún marek.behun@nic.cz wrote:
Commit 173ec351 ("i2c: mvtwsi: disable i2c slave on Armada 38x") adds slave disabling code on port 0 into bind method. This does not work on Turris Omnia in SPL, because at the time the bind method is called in SPL, arch/arm/mach-mvebu/spl.c has not yet set DM translation offset, so the bind function reads from bad memory place, which causes a fault.
Move the i2c slave disabling code into the probe method of mvtwsi, by that time dm_set_translation_offset is already called.
https://patchwork.ozlabs.org/patch/1084776/ implements a better fix for this issue and has been merged in master with the latest DM pull 2h ago.
-- Pierre Bourdon delroth@gmail.com Software Engineer @ Zürich, Switzerland https://delroth.net/