In message 1199914268-29217-1-git-send-email-plagnioj@jcrosoft.com you wrote:
allow to use a different server as set in serverip
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagnioj@jcrosoft.com
diff --git a/common/cmd_net.c b/common/cmd_net.c index 21682c0..e03ffbf 100644 --- a/common/cmd_net.c +++ b/common/cmd_net.c @@ -51,7 +51,7 @@ int do_tftpb (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[]) U_BOOT_CMD( tftpboot, 3, 1, do_tftpb, "tftpboot- boot image via network using TFTP protocol\n",
- "[loadAddress] [bootfilename]\n"
- "[loadAddress] [[host ip addr]:bootfilename]\n"
NAK.
Ben, please don't apply. I reject this patch.
Jean-Christophe - as already discussed on IRC I really ask you to pay attemtion to gvb's comments on your patch:
| Critique: the help is misleading: "host ip addr:" is optional so it | needs another set of [] around it. Having spaces in "host ip addr" is | more readable, but makes it look like it is three things or perhaps a | keyword. | | I would suggest the following, but there may be a better way... | "[loadAddress] [[hostIPaddr:]bootfilename]\n"
Also make sure that you place the ';' in the right pair of brackets.
Best regards,
Wolfgang Denk