Dear Bo Shen,
Am Dienstag, 21. August 2012 schrieb Bo Shen :
On 8/17/2012 0:01, Andreas Bießmann wrote:
A lot of at91 boards have the console_init_f in board_init. This is useless cause it was called before by generic code in lib/board.c.
Signed-off-by: Andreas Bießmann andreas.devel@googlemail.com cc: Jens Scharsig esw@bus-elektronik.de cc: Stelian Pop stelian@popies.net cc: Sedji Gaouaousedji.gaouaou@atmel.com cc: Albin Tonnerre albin.tonnerre@free-electrons.com cc: Eric Benard eric@eukrea.com
board/BuS/eb_cpux9k2/cpux9k2.c | 2 -- board/BuS/vl_ma2sc/vl_ma2sc.c | 3 --- board/atmel/at91sam9261ek/**at91sam9261ek.c | 3 --- board/atmel/at91sam9m10g45ek/**at91sam9m10g45ek.c | 3 --- board/atmel/at91sam9rlek/**at91sam9rlek.c | 3 --- board/calao/sbc35_a9g20/sbc35_**a9g20.c | 3 --- board/calao/tny_a9260/tny_**a9260.c | 3 --- board/eukrea/cpuat91/cpuat91.c | 2 -- 8 files changed, 22 deletions(-)
diff --git a/board/BuS/eb_cpux9k2/**cpux9k2.c b/board/BuS/eb_cpux9k2/** cpux9k2.c index 54f9b64..776226f 100644 --- a/board/BuS/eb_cpux9k2/**cpux9k2.c +++ b/board/BuS/eb_cpux9k2/**cpux9k2.c @@ -59,8 +59,6 @@ DECLARE_GLOBAL_DATA_PTR; int board_init(void) { at91_pio_t *pio = (at91_pio_t *) ATMEL_BASE_PIO;
/* Enable Ctrlc */console_init_f(); /* Correct IRDA resistor problem / Set PA23_TXD in Output */ writel(ATMEL_PMX_AA_TXD2, &pio->pioa.oer);diff --git a/board/BuS/vl_ma2sc/vl_ma2sc.**c b/board/BuS/vl_ma2sc/vl_ma2sc.**c index 62ed6fb..84b2060 100644 --- a/board/BuS/vl_ma2sc/vl_ma2sc.**c +++ b/board/BuS/vl_ma2sc/vl_ma2sc.**c @@ -244,9 +244,6 @@ int board_init(void) writel(pin, &pio->piod.odr); writel(pin, &pio->piod.owdr);
/* Enable Ctrlc */console_init_f();gd->bd->bi_arch_number = MACH_TYPE_VL_MA2SC; /* adress of boot parameters */ gd->bd->bi_boot_params = CONFIG_SYS_SDRAM_BASE + 0x100;diff --git a/board/atmel/at91sam9261ek/**at91sam9261ek.c b/board/atmel/at91sam9261ek/**at91sam9261ek.c index 47ab839..d30a1ee 100644 --- a/board/atmel/at91sam9261ek/**at91sam9261ek.c +++ b/board/atmel/at91sam9261ek/**at91sam9261ek.c @@ -242,9 +242,6 @@ void lcd_show_board_info(void)
int board_init(void) {
/* Enable Ctrlc */console_init_f();Tested on at91sam9g10ek board. It works well without this.
FYI: If you had used the well known git 'tag' Tested-by this would be added automagically to patchworks patch. Please read http://www.denx.de/wiki/view/U-Boot/Patches#Review_Process_Git_Tags However, thanks for your test report.
Best regards
Andreas Bießmann