On Fri, Aug 25, 2023 at 05:30:17PM +0530, Sughosh Ganu wrote:
On Fri, 25 Aug 2023 at 01:29, Simon Glass sjg@chromium.org wrote:
Use a menuconfig to avoid showing a menu which cannot be selected in many cases.
This option should really go with the other 'Update support'.
Perhaps we should even consider a top-level update/ directory?
Signed-off-by: Simon Glass sjg@chromium.org
nit: s/FMU/FWU in the commit header.
Acked-by: Sughosh Ganu sughosh.ganu@linaro.org
-sughosh
lib/Kconfig | 4 ---- lib/fwu_updates/Kconfig | 6 +++++- 2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/lib/Kconfig b/lib/Kconfig index 9addcfab3734..bfab2f3165a7 100644 --- a/lib/Kconfig +++ b/lib/Kconfig @@ -1118,8 +1118,4 @@ config PHANDLE_CHECK_SEQ
endmenu
-menu "FWU Multi Bank Updates"
source lib/fwu_updates/Kconfig
-endmenu diff --git a/lib/fwu_updates/Kconfig b/lib/fwu_updates/Kconfig index 71f34793d926..be35ad29fa32 100644 --- a/lib/fwu_updates/Kconfig +++ b/lib/fwu_updates/Kconfig @@ -1,4 +1,4 @@ -config FWU_MULTI_BANK_UPDATE +menuconfig FWU_MULTI_BANK_UPDATE bool "Enable FWU Multi Bank Update Feature" depends on EFI_CAPSULE_ON_DISK select PARTITION_TYPE_GUID @@ -10,6 +10,8 @@ config FWU_MULTI_BANK_UPDATE multiple banks(copies) of the firmware images. One of the bank is selected for updating all the firmware components
+if FWU_MULTI_BANK_UPDATE
config FWU_NUM_BANKS int "Number of Banks defined by the platform" depends on FWU_MULTI_BANK_UPDATE
Looks like the rest of this Kconfig needs to be updated to not have depends on FWU_MULTI_BANK_UPDATE if it's all guarded with an if on that.