Re: [U-Boot] [U-Boot, v2] fuelgauge: max17042: fix i2c read issue which causes infinity loop.

On Mon, Dec 30, 2013 at 11:24:32AM +0100, Przemyslaw Marczak wrote:

Issues:

• reading i2c data by passing u16 pointer causes errors in read data.
• max17042 status register fields have not only Power On Reset meaning so using proper mask is required.

Changes:

• read i2c data to type u32 instead of u16 - avoids buffer overflow
• compare FG status register using mask not just one bit value
• add checking return value to functions fg read/write
• add model lock and model check count
• add debug msg

Signed-off-by: Przemyslaw Marczak p.marczak@samsung.com Cc: Lukasz Majewski l.majewski@samsung.com Cc: Minkyu Kang mk7.kang@samsung.com

Applied to u-boot/master, thanks!