Re: [U-Boot] [PATCH v5 1/8] those files are jz4740 base files

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1

Hi Wolfgang Denk

On 01/18/2011 05:35 AM, Wolfgang Denk wrote:

Please do not use base + offset notation. Declare a proper C struct instead. Please fix globally.

...

...

• /* Disable port interrupts while changing hardware */
• *uart_ier = 0;

And use proper I/O accessors to access device registers. Please fix globally.

I have delete all base + offset. using C struct now. and using proper I/O accressors

...

...

...

+static ulong timestamp; +static ulong lastdec;

As already has been pointed out several times before: this will not work because BSS cannot be accessed before relocation.

can you give me some tips how to fix this?

thanks

- -- Best Regards Xiangfu Liu http://www.openmobilefree.net