Re: [U-Boot] [PATCH v2 1/2] ARM: Move SYS_CACHELINE_SIZE over to Kconfig

On Mon, Aug 22, 2016 at 04:44:51PM +0200, Ladislav Michl wrote:

On Mon, Aug 22, 2016 at 08:22:17AM -0400, Tom Rini wrote: [snip]

...

diff --git a/include/configs/cm_t3517.h b/include/configs/cm_t3517.h index ea9983bc7d43..a89ccb73b178 100644 --- a/include/configs/cm_t3517.h +++ b/include/configs/cm_t3517.h @@ -10,8 +10,6 @@ #ifndef __CONFIG_H #define __CONFIG_H

-#define CONFIG_SYS_CACHELINE_SIZE 64

/*

• High Level Configuration Options

*/ @@ -30,7 +28,6 @@

• Although the default iss 64, we still define it
• to be on the safe side once the default is changed.

*/

That comment above probably looses sense with define removed...

Ah, thanks! I'll update that for a v3 and check it all over again for similar comments.

...

-#define CONFIG_SYS_CACHELINE_SIZE 64

#define CONFIG_EMIF4 /* The chip has EMIF4 controller */

regards, ladis

PS. Tested on OMAP3 IGEPv2 and TAM-3517 boards

Thanks!